This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
[v0.9] Remove penalties on recovery and on missed PoSt (FIP-0002) #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
force-pushed
the
anorth/09penalties
branch
from
e630995 to
db4642b
Compare
Codecov Report
@@ Coverage Diff @@
## release/v0.9 #1181 +/- ##
==============================================
- Coverage 73.2% 73.2% -0.1%
==============================================
Files 51 51
Lines 5450 5470 +20
==============================================
+ Hits 3994 4006 +12
- Misses 876 877 +1
- Partials 580 587 +7 |
anorth
force-pushed
the
anorth/09penalties
branch
from
db4642b to
d006413
Compare
anorth
changed the title
ZenGround0
reviewed
Sep 24, 2020
| ongoingFaultyPower := deadline.FaultyPower.QA | ||
| if networkVersion >= network.Version3 { | ||
| // From network version 3, this *excludes* any power that was just faulted from missing a PoSt. | ||
| ongoingFaultyPower = previouslyFaultyPower |
There was a problem hiding this comment.
@lucaniz @irenegia I looked over this again and it appears to be correct. previouslyFaultPower already accounts for failedRecoveryPower (we only handle failedRecoveryPower separately in the previous version because we used to charge this power SP). Another way to put it, the value of deadline.FaultyPower.QA at line 1683 after processing deadline end = previouslyFaultPower - newFaultyPower
anorth
changed the title
anorth
force-pushed
the
anorth/09penalties
branch
from
d006413 to
59f1a03
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honest miners are sometimes disproportionately penalized for operational failures and network congestion by the high undeclared-fault penalty (aka SP) for missed Window PoSts. This change reduces those costs without sacrificing much of the incentive to maintain reliable storage.
Summary:
As a result of this, declaring faults in advance confers no advantage compared with skipping them at Window PoSt. The DeclareFaults method remains, but may be removed in the future.
This change is a demonstration of upcoming FIP-0002, which will describe more background and rationale.
Note that the new values are not directly tested in this PR. I intend to replicate on the
v2line and change all the tests there. UPDATE: see #1183FYI @Stebalien @magik6k @whyrusleeping @zixuanzh @nicola